Specify how to obtain all inverses #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, I see there is a discrepancy with spacing in Latex code. In this docstring it is written |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1835 +/- ##
==========================================
+ Coverage 88.12% 88.13% +0.01%
==========================================
Files 119 119
Lines 29982 29982
==========================================
+ Hits 26423 26426 +3
+ Misses 3559 3556 -3 ☔ View full report in Codecov by Sentry. |
fingolfin
reviewed
Oct 7, 2024
fingolfin
reviewed
Oct 7, 2024
fingolfin
reviewed
Oct 7, 2024
| @@ -3558,6 +3558,8 @@ If `side` is `:right` and `flag` is true, $B$ is the right inverse of $A$ | |||
| i.e. $AB$ is the $n\times n$ unit matrix. If `side` is `:left` and `flag` is | |||
| true, $B$ is the left inverse of $A$ i.e. $BA$ is the $m\times m$ unit matrix. | |||
| If `flag` is false, no right or left inverse exists. | |||
|
|
|||
| To get the space of all inverses, combine with [`nullspace`](@ref). | |||
| """ | |||
| function is_invertible_with_inverse(A::MatrixElem{T}; side::Symbol = :left) where {T <: RingElement} | |||
There was a problem hiding this comment.
Not an issue of this PR, but for the record: I am surprised that this function can do strictly more (namely handle non-square matrices) than its is_invertible sibling.
thofma
reviewed
Oct 7, 2024
albinahlback
force-pushed
the
all_inverses
branch
from
9ca1b3d
to
439502b
Compare
In docstring for `is_invertible_with_inverse`. Co-authored-by: Max Horn <max@quendi.de> Co-authored-by: Tommy Hofmann <thofma@gmail.com>
albinahlback
force-pushed
the
all_inverses
branch
from
439502b
to
7298a3d
Compare
|
Should be ready to go! |
fingolfin
reviewed
Oct 7, 2024
fingolfin
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves oscar-system/Oscar.jl#4179