Use IntUnaryOperator / DoubleUnaryOperator in VegasLimit #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to IntUnaryOperator and DoubleUnaryOperator in VegasLimit to avoid unnecessary boxing. Additionally, reduced repeated reads of volatile fields.
kilink
commented
Sep 19, 2024
|
|
||
| /** | ||
| * Function used by limiters to calculate thredsholds using log10 of the current limit. | ||
| * Here we pre-compute the log10 of numbers up to 1000 as an optimization. | ||
| */ | ||
| public final class Log10RootFunction implements Function<Integer, Integer> { | ||
| public final class Log10RootFunction implements IntUnaryOperator { |
There was a problem hiding this comment.
Not backwards compatible, but I'd be surprised if this is widely used outside of the library itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to IntUnaryOperator and DoubleUnaryOperator in VegasLimit to avoid unnecessary boxing. Additionally, reduced repeated reads of volatile fields.