Add getSourceOrThrow helper method to DgsDataFetchingEnvironment #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphql-java 22.1 added nullability annotations to DataFetchingEnvironment methods such as getSource, which can make make the call-site overly verbose from Kotlin since the caller must handle the possibility of null. In this particular case, the method always returns a non-null value unless being called from the context of the root query, so having a helper that returns a non-null value is more ergonomic.
paulbakker
approved these changes
Jun 26, 2024
srinivasankavitha
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-java 22.1 added nullability annotations to DataFetchingEnvironment methods such as getSource, which can make make the call-site overly verbose from Kotlin since the caller must handle the possibility of null. In this particular case, the method always returns a non-null value unless being called from the context of the root query, so having a helper that returns a non-null value is more ergonomic.