Register jdk8 module in DgsSSESubscriptionHandler #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasankavitha
approved these changes
Jun 27, 2024
kilink
reviewed
Jun 27, 2024
...s-sse/src/main/kotlin/com/netflix/graphql/dgs/subscriptions/sse/DgsSSESubscriptionHandler.kt
Outdated
Show resolved
Hide resolved
kailyak
force-pushed
the
configure-jackson-mapper-for-jdk8-support
branch
from
d76f24f
to
1294a1a
Compare
kailyak
force-pushed
the
configure-jackson-mapper-for-jdk8-support
branch
from
1294a1a
to
2715ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Describe the new behavior from this PR, and why it's needed
Internally the use case arose for needing to serialize java 8 Optionals in SSE subscription calls. Since the object mapper in DgsSSESubscriptionHandler is not configured for the Jdk8 module an error was thrown when that type was part of the payload here.
Testing done
Tested on app which had the serialization error.