Add ability to supply custom ObjectMapper to clients #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbakker
reviewed
Aug 1, 2024
There was a problem hiding this comment.
This has been deprecated for a very long time, but I do see a bunch of internal usage (Netflix) still.
Not sure if it's worth removing it right now.
There was a problem hiding this comment.
Okay, I brought back the deprecated client, but didn't implement this feature there.
kilink
force-pushed
the
client-custom-object-mapper
branch
3 times, most recently
from
7243743
to
96ee7e2
Compare
Add constructors / static factory methods to allow supplying a custom ObjectMapper to the GraphQL clients, which can be useful when the user needs precise control over serialization. Additionally, remove deprecated DefaultGraphQLClient, fix various tests, and simplify serialization of the request body to avoid needing the KotlinModule installed at all.
kilink
force-pushed
the
client-custom-object-mapper
branch
from
96ee7e2
to
3a8f6f5
Compare
paulbakker
approved these changes
Aug 2, 2024
srinivasankavitha
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constructors / static factory methods to allow supplying a custom ObjectMapper to the GraphQL clients, which can be useful when the user needs precise control over serialization.
Additionally, remove deprecated DefaultGraphQLClient, fix various tests, and simplify serialization of the request body to avoid needing the KotlinModule installed at all.