Support Kotlin value class parameters to data fetchers #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support Kotlin value class parameters as top-level arguments to data fetcher methods. Fixes #355
| @@ -44,6 +47,19 @@ abstract class AbstractInputArgumentResolver(inputObjectMapper: InputObjectMappe | |||
| val argumentName = getArgumentName(parameter) | |||
| val value = dfe.getArgument<Any?>(argumentName) | |||
|
|
|||
| val kfunc = parameter.method?.kotlinFunction | |||
| if (kfunc != null) { | |||
| val parameterIdx = if (kfunc.parameters.first().kind == KParameter.Kind.INSTANCE) { | |||
There was a problem hiding this comment.
What does this check mean?
There was a problem hiding this comment.
The first parameter to the KFunction is the instance parameter, e.g. the instance the method is being called on, so we need to adjust the parameter index based on that (essentially start the indexing after this instance parameter).
srinivasankavitha
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Kotlin value class parameters as top-level arguments to data fetcher methods.
Fixes #355