Remove locking from DgsSchemaProvider #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilink
force-pushed
the
remove-schema-provider-lock
branch
from
7eeaa66
to
e08e7bc
Compare
DgsSchemaProvider used a ReentrantReadWriteLock to guard access to mutable fields that are populated during schema generation. Remove the need for the lock by combining the mutable fields into a immutable holder, DataFetcherInfo, the instance of which is accessible via an AtomicReference.
kilink
force-pushed
the
remove-schema-provider-lock
branch
from
e08e7bc
to
58b8039
Compare
paulbakker
approved these changes
Aug 13, 2024
srinivasankavitha
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DgsSchemaProvider used a ReentrantReadWriteLock to guard access to mutable fields that are populated during schema generation; remove the need for the lock by combining the mutable fields into a single class, DataFetcherInfo, the instance of which is accessible via an AtomicReference; the schema method no longer needs to mutate fields on the DgsSchemaProvider directly, and the only thing stored on the schema provider itself is immutable.