Fix setup of exception handling to make @ControllerAdvice work #2040
+160
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbakker
requested review from
kilink,
srinivasankavitha,
iuliiasobolevska,
kzwang,
asibross,
iparadiso and
jjacobs44
as code owners
paulbakker
force-pushed
the
fix/fix-controller-advice
branch
from
3f81392
to
ce38800
Compare
srinivasankavitha
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2017
Don't explicitly set an execution strategy when not provided by the user. This would disable the configured exception handling from spring-graphql.
This bug was previously there, but hidden because of another bug. Since this bug was fixed it exposed this issue.