confirmed that the reert_error also covers rejected errors

NethermindEth · Oct 8, 2024 · f6fe3b9 · f6fe3b9
1 parent 1f340d5
commit f6fe3b9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/rpc/transaction.go b/rpc/transaction.go
@@ -795,7 +795,7 @@ func adaptTransactionStatus(txStatus *starknet.TransactionStatus) (*TransactionS
 		status.Execution = TxnFailure
 	case starknet.Rejected:
 		status.Finality = TxnStatusRejected
-		status.FailureReason = txStatus.RevertError // Todo: placeholder - does revertError also hold the error for Rejected Txns?
+		status.FailureReason = txStatus.RevertError
 	default: // Omit the field on error. It's optional in the spec.
 	}