Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown during db migration #1163

Open
IronGauntlets opened this issue Aug 24, 2023 · 1 comment · Fixed by #1169
Open

Graceful shutdown during db migration #1163

IronGauntlets opened this issue Aug 24, 2023 · 1 comment · Fixed by #1169
Labels
DB Database

Comments

@IronGauntlets
Copy link
Contributor

If there is a long db migration taking place there is no way to gracefully Juno. Any force shutdown corrupts the DB.

Juno should be able to gracefully shutdown during the migration and pick up where it left off when Juno is restarted.
@Exca-DK Exca-DK mentioned this issue Aug 25, 2023
Merged
@IronGauntlets IronGauntlets added the DB Database label Sep 20, 2023
Exca-DK added a commit to Exca-DK/juno that referenced this issue Oct 30, 2023
@Exca-DK
Enhance Migration: Introduce Intermediate State for graceful cancella…
d7c63b7 
…tion support.

implements NethermindEth#1163
Exca-DK added a commit to Exca-DK/juno that referenced this issue Nov 2, 2023
@Exca-DK
Enhance Migration: Introduce Intermediate State for graceful cancelat…
b66fa6a 
…ion support.

implements NethermindEth#1163
Exca-DK added a commit to Exca-DK/juno that referenced this issue Nov 22, 2023
@Exca-DK
Enhance Migration: Introduce migration cancellation.
2f56ed9 
Changes:
- Migrations support intermediate step for resumption.
- Migration accepts context for cancellation
- Migration schema includes persistent `IntermediateState`

Implements NethermindEth#1163
Exca-DK added a commit to Exca-DK/juno that referenced this issue Nov 22, 2023
@Exca-DK
Enhance Migration: Introduce migration cancellation.
9d19a66 
Changes:
    - Migrations support intermediate step for resumption.
    - Migration accepts context for cancellation
    - Migration schema includes persistent `IntermediateState`

Implements NethermindEth#1163
joshklop pushed a commit that referenced this issue Nov 22, 2023
@Exca-DK
Introduce migration cancellation (#1169)
160225f 
Changes:
    - Migration accepts context for cancellation
    - Migration schema includes persistent `IntermediateState`

Towards #1163

Co-authored-by: Exca-DK <Exca-DK@users.noreply.github.com>
@joshklop joshklop reopened this Nov 22, 2023
@joshklop
Copy link
Contributor

Linked PR allows for cancellation between migrations, but not during a migration. The latter was deliberately left for after regenesis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DB Database
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migration: Gracefull cancelation Exca-DK/juno
2 participants
@IronGauntlets @joshklop