Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename trie/TransactionStorage to Storage #1783

Closed
IronGauntlets opened this issue Apr 2, 2024 · 4 comments
Closed

Rename trie/TransactionStorage to Storage #1783

IronGauntlets opened this issue Apr 2, 2024 · 4 comments
Labels
Good first issue Good for newcomers Trie

Comments

@IronGauntlets
Copy link
Contributor

Reduce the overloading of the Transaction keyword.
@IronGauntlets IronGauntlets added Good first issue Good for newcomers Trie labels Apr 2, 2024
nsiregar added a commit to nsiregar/juno that referenced this issue Apr 3, 2024
@nsiregar
Rename trie/TransactionStorage to Storage (NethermindEth#1783)
8e981f5
@nsiregar nsiregar mentioned this issue Apr 3, 2024
Merged
nsiregar added a commit to nsiregar/juno that referenced this issue Apr 4, 2024
@nsiregar
Rename trie/TransactionStorage to Storage (NethermindEth#1783)
9b78c67
@danielcdz
Copy link

@IronGauntlets Can this be assigned to me?

nsiregar added a commit to nsiregar/juno that referenced this issue Apr 21, 2024
@nsiregar
Rename trie/TransactionStorage to Storage (NethermindEth#1783)
1c4d9cd
@CodeMongerrr
Copy link

This issue has been worked on completely right?

kirugan pushed a commit to nsiregar/juno that referenced this issue Jul 2, 2024
@nsiregar @kirugan
Rename trie/TransactionStorage to Storage (NethermindEth#1783)
bb38cd1
kirugan pushed a commit to nsiregar/juno that referenced this issue Jul 9, 2024
@nsiregar @kirugan
Rename trie/TransactionStorage to Storage (NethermindEth#1783)
045ad6b
@diegoTech14
Copy link

diegoTech14 commented Jul 15, 2024 •
edited
Loading

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello @IronGauntlets,

I'm Diego Duarte from Costa Rica, and I would like to help with this issue. I am a Web3 learner but I have experience developing in Web2.

For this issue I will change all the 'trie/TransactionStorage' matches to 'Storage'

Here is my OD profile.

Best regards,
Diego Duarte

Thanks for your consideration!

kirugan pushed a commit to nsiregar/juno that referenced this issue Jul 16, 2024
@nsiregar @kirugan
Rename trie/TransactionStorage to Storage (NethermindEth#1783)
2b31555
@kirugan
Copy link
Contributor

kirugan commented Jul 17, 2024

I'm closing it because everything was imlemented already

@kirugan kirugan closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Good for newcomers Trie
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kirugan @IronGauntlets @danielcdz @diegoTech14 @CodeMongerrr