Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feeder types for Starknet 0.12.1 #882

Closed
joshklop opened this issue Jul 4, 2023 · 0 comments · Fixed by #895
Closed

Update feeder types for Starknet 0.12.1 #882

joshklop opened this issue Jul 4, 2023 · 0 comments · Fixed by #895
Labels
Good first issue Good for newcomers

Comments

@joshklop
Copy link
Contributor

joshklop commented Jul 4, 2023

Problem: Currently, we don't include the status in the feeder.Transaction struct. However, it is present in the response from the feeder gateway (example). This isn't a problem for us since we calculate the status on the fly in the rpc handler, but it could be a problem for developers who import the feeder package.

Solution: include all fields present in the feeder gateway response in the feeder.Transaction struct. We need to make the changes below.

With 0.12.1, the status enum is changing to include RECEIVED, REJECTED, REVERTED, ACCEPTED_ON_L2, ACCEPTED_ON_L1

Two more status enums are being added (related to #881):

  • execution_status: REJECTED, REVERTED, SUCCEEDED
  • finality_status: RECEIVED, ACCEPTED_ON_L2, ACCEPTED_ON_L1
@joshklop joshklop added the Good first issue Good for newcomers label Jul 4, 2023
@joshklop joshklop linked a pull request Jul 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant