Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types for 0.12.1 #895

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Update types for 0.12.1 #895

merged 1 commit into from
Jul 10, 2023

Conversation

joshklop
Copy link
Contributor

@joshklop joshklop commented Jul 9, 2023 •
edited
Loading

Needed for #878. See commit message for details.

@joshklop joshklop marked this pull request as draft July 9, 2023 05:56
@joshklop joshklop marked this pull request as ready for review July 9, 2023 22:41
@joshklop joshklop requested review from a team and kirugan and removed request for a team July 9, 2023 22:41
@codecov
Copy link

codecov bot commented Jul 9, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (017cfbe) 72.63% compared to head (101f060) 72.67%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
+ Coverage   72.63%   72.67%   +0.03%     
==========================================
  Files          56       57       +1     
  Lines        5942     5961      +19     
==========================================
+ Hits         4316     4332      +16     
- Misses       1261     1263       +2     
- Partials      365      366       +1
Impacted Files Coverage Δ
core/transaction.go 79.54% <ø> (ø)
adapters/feeder2core/feeder2core.go 85.92% <100.00%> (+0.05%) ⬆️
clients/feeder/transaction.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joshklop joshklop force-pushed the joshklop/feeder-0.12.1 branch 3 times, most recently from f934082 to b9c2693 Compare July 10, 2023 01:17
@joshklop joshklop linked an issue Jul 10, 2023 that may be closed by this pull request
Update feeder types for Starknet 0.12.1 #882
Closed
@joshklop joshklop force-pushed the joshklop/feeder-0.12.1 branch 2 times, most recently from 855f8b7 to 101f060 Compare July 10, 2023 15:55
@joshklop
Update types for 0.12.1 changes
101f060 
- Add ExecutionStatus to feeder type
- Add Reverted field to core type
@joshklop joshklop merged commit 3e989ed into main Jul 10, 2023
8 checks passed
@joshklop joshklop deleted the joshklop/feeder-0.12.1 branch July 10, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerfirmak omerfirmak omerfirmak approved these changes

@kirugan kirugan Awaiting requested review from kirugan kirugan was automatically assigned from NethermindEth/nubia-juno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update feeder types for Starknet 0.12.1
2 participants
@joshklop @omerfirmak