Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement casm class hash calculation #1154

Merged
merged 16 commits into from
Nov 27, 2023
Merged

Implement casm class hash calculation #1154

merged 16 commits into from
Nov 27, 2023

Conversation

Brivan-26
Copy link
Contributor

@Brivan-26 Brivan-26 self-assigned this Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (a6b8453) 72.68% compared to head (02f4fd8) 72.56%.

Files Patch % Lines
adapters/core2sn/core2sn.go 52.52% 44 Missing and 3 partials ⚠️
utils/slices.go 0.00% 12 Missing ⚠️
adapters/sn2core/sn2core.go 87.87% 2 Missing and 2 partials ⚠️
clients/feeder/feeder.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1154      +/-   ##
==========================================
- Coverage   72.68%   72.56%   -0.13%     
==========================================
  Files          93       94       +1     
  Lines        9732     9888     +156     
==========================================
+ Hits         7074     7175     +101     
- Misses       2125     2177      +52     
- Partials      533      536       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brivan-26 Brivan-26 requested review from a team and removed request for a team August 23, 2023 14:45
@Brivan-26 Brivan-26 changed the title Abdessamed/implement casm class hash calculation Implement casm class hash calculation Aug 23, 2023
joshklop
joshklop requested changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@joshklop joshklop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the compiled class hash calculation documented?

core/class.go Outdated Show resolved Hide resolved
core/class.go Outdated Show resolved Hide resolved
core/class.go Outdated Show resolved Hide resolved
core/class.go Outdated Show resolved Hide resolved
vm/class.go Outdated Show resolved Hide resolved
core/class.go Outdated Show resolved Hide resolved
core/class.go Outdated Show resolved Hide resolved
@Brivan-26
Copy link
Contributor Author

Where is the compiled class hash calculation documented?

https://github.com/xJonathanLEI/starknet-rs/blob/e9bdd7efeae9c76ef62a130ccef3f4355a864797/starknet-core/src/types/contract/mod.rs#L376

joshklop
joshklop requested changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@joshklop joshklop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small things. Let's wait to see if there's an answer on the Cairo prime thing before merging.

core/class.go Outdated Show resolved Hide resolved
core/class.go Outdated Show resolved Hide resolved
vm/class.go Outdated Show resolved Hide resolved
joshklop
joshklop reviewed Sep 11, 2023
View reviewed changes
adapters/feeder2core/feeder2core.go Outdated Show resolved Hide resolved
adapters/feeder2core/feeder2core.go Outdated Show resolved Hide resolved
adapters/feeder2core/feeder2core.go Outdated Show resolved Hide resolved
adapters/feeder2core/feeder2core.go Outdated Show resolved Hide resolved
adapters/feeder2core/feeder2core.go Outdated Show resolved Hide resolved
@kirugan kirugan force-pushed the abdessamed/implement_casmClass_hash_calculation branch 2 times, most recently from 99b1a71 to 914981b Compare November 24, 2023 11:10
joshklop
joshklop reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@joshklop joshklop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies if I started reviewing before it was ready. Didn't see it was still wip until I was half-way through :)

...ration/compiled_class/0x6d8ede036bb4720e6f348643221d8672bf4f0895622c32c11e57460b3b7dffc.json Outdated Show resolved Hide resolved
vm/class.go Outdated Show resolved Hide resolved
@kirugan kirugan force-pushed the abdessamed/implement_casmClass_hash_calculation branch 2 times, most recently from 6470588 to af7b21b Compare November 27, 2023 09:40
@kirugan kirugan force-pushed the abdessamed/implement_casmClass_hash_calculation branch from 233b8ee to 1d658d0 Compare November 27, 2023 14:25
joshklop
joshklop reviewed Nov 27, 2023
View reviewed changes
core/class_test.go Show resolved Hide resolved
core/class.go Show resolved Hide resolved
adapters/core2sn/core2sn.go Outdated Show resolved Hide resolved
core/class.go Outdated Show resolved Hide resolved
vm/class.go Show resolved Hide resolved
@kirugan kirugan force-pushed the abdessamed/implement_casmClass_hash_calculation branch 2 times, most recently from efbe412 to fb53bac Compare November 27, 2023 17:31
@kirugan kirugan force-pushed the abdessamed/implement_casmClass_hash_calculation branch 3 times, most recently from 12f6cb4 to ecc23d1 Compare November 27, 2023 20:16
@kirugan kirugan force-pushed the abdessamed/implement_casmClass_hash_calculation branch from ecc23d1 to 02f4fd8 Compare November 27, 2023 21:12
@kirugan kirugan merged commit 9bac881 into main Nov 27, 2023
9 of 10 checks passed
@kirugan kirugan deleted the abdessamed/implement_casmClass_hash_calculation branch November 27, 2023 21:28
kirugan added a commit that referenced this pull request Nov 28, 2023
@kirugan
Revert "Implement casm class hash calculation (#1154)"
e3ea5c1 
This reverts commit 9bac881.
kirugan added a commit that referenced this pull request Nov 28, 2023
@kirugan
Revert "Implement casm class hash calculation (#1154)" (#1474)
9448c9f 
This reverts commit 9bac881.
kirugan added a commit that referenced this pull request Nov 28, 2023
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
ff972d7 
This reverts commit 9448c9f.
kirugan added a commit that referenced this pull request Dec 3, 2023
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
8ff0b85 
This reverts commit 9448c9f.
kirugan added a commit that referenced this pull request Dec 5, 2023
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
634c46d 
This reverts commit 9448c9f.
kirugan added a commit that referenced this pull request Dec 5, 2023
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
911509d 
This reverts commit 9448c9f.
kirugan added a commit that referenced this pull request Dec 5, 2023
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
b4959bb 
This reverts commit 9448c9f.
kirugan added a commit that referenced this pull request Dec 12, 2023
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
bb54871 
This reverts commit 9448c9f.
kirugan added a commit that referenced this pull request Dec 15, 2023
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
c4c320d 
This reverts commit 9448c9f.
kirugan added a commit that referenced this pull request Dec 19, 2023
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
9fc8b71 
This reverts commit 9448c9f.
kirugan added a commit that referenced this pull request Dec 19, 2023
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
bf935af 
This reverts commit 9448c9f.
kirugan added a commit that referenced this pull request Jan 5, 2024
@kirugan
Revert "Revert "Implement casm class hash calculation (#1154)" (#1474)"
c71ba24 
This reverts commit 9448c9f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirugan kirugan kirugan left review comments

@joshklop joshklop joshklop approved these changes

@omerfirmak omerfirmak Awaiting requested review from omerfirmak

Assignees

@Brivan-26 Brivan-26

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement CasmClass (ie Cairo1 Compiled Class) hash calculation
3 participants
@Brivan-26 @kirugan @joshklop