Account for query bit when switching on txn version for hashing #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes a fix to felt.IsOne()
omerfirmak
requested review from
a team and
IronGauntlets
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
==========================================
- Coverage 73.71% 73.68% -0.04%
==========================================
Files 70 70
Lines 7530 7554 +24
==========================================
+ Hits 5551 5566 +15
- Misses 1523 1529 +6
- Partials 456 459 +3
☔ View full report in Codecov by Sentry. |
joshklop
reviewed
Sep 14, 2023
omerfirmak
force-pushed
the
omerfirmak/txn-version
branch
from
0f71681
to
6dda97e
Compare
joshklop
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.