Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused RPC error #1237

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Remove unused RPC error #1237

merged 1 commit into from
Sep 15, 2023

Conversation

joshklop
Copy link
Contributor

No description provided.

@joshklop joshklop requested review from a team and kirugan and removed request for a team September 14, 2023 20:01
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7a816ed) 73.73% compared to head (0892fc8) 73.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1237   +/-   ##
=======================================
  Coverage   73.73%   73.73%           
=======================================
  Files          70       70           
  Lines        7554     7554           
=======================================
  Hits         5570     5570           
+ Misses       1527     1526    -1     
- Partials      457      458    +1     
Files Changed Coverage Δ
rpc/handlers.go 77.04% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omerfirmak
Copy link
Contributor

Do you think it makes sense to return this for blocks that we cannot successfully run with blockifier? Old blocks for example

@joshklop
Copy link
Contributor Author

Do you think it makes sense to return this for blocks that we cannot successfully run with blockifier? Old blocks for example

No. The spec requires us to indicate why the trace is not available in the Data field by setting it to RECEIVED or REJECTED. i.e., the trace is not available because the transaction is invalid or because the sequencer hasn't traced it yet.

The error shouldn't be part of the spec imho--I think it was mistakenly copied from the feeder, where it would make more sense in the context of caching traces.

@joshklop joshklop merged commit b20cea1 into main Sep 15, 2023
10 checks passed
@joshklop joshklop deleted the joshklop/unused-err branch September 15, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants