Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Synchronizer fields private #1240

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Make Synchronizer fields private #1240

merged 1 commit into from
Sep 15, 2023

Conversation

omerfirmak
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 78.78% and project coverage change: -0.07% ⚠️

Comparison is base (b20cea1) 73.73% compared to head (92896cd) 73.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   73.73%   73.66%   -0.07%     
==========================================
  Files          70       70              
  Lines        7554     7561       +7     
==========================================
  Hits         5570     5570              
- Misses       1526     1534       +8     
+ Partials      458      457       -1     
Files Changed Coverage Δ
sync/sync.go 83.09% <75.00%> (-2.10%) ⬇️
rpc/handlers.go 77.04% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omerfirmak omerfirmak merged commit 935eb23 into main Sep 15, 2023
10 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/sync-private branch September 15, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants