-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store empty pending block instead of deleting the key #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
reviewed
Sep 15, 2023
While Juno is syncing:
Are these behavior changes acceptable? |
I think that is fine
This I am not sure of |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
- Coverage 73.65% 73.65% -0.01%
==========================================
Files 70 70
Lines 7561 7594 +33
==========================================
+ Hits 5569 5593 +24
- Misses 1533 1540 +7
- Partials 459 461 +2
☔ View full report in Codecov by Sentry. |
joshklop
force-pushed
the
joshklop/dont-clear-pending
branch
3 times, most recently
from
September 16, 2023 14:35
94c1eb4
to
0ea311d
Compare
To decrease the number of `block not found` errors when simulating transactions against the pending block.
omerfirmak
reviewed
Sep 17, 2023
omerfirmak
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To decrease the number of
block not found
errors when simulating transactions against the pending block.