Discard database txn if user callback panics #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
force-pushed
the
omerfirmak/panicing-service
branch
from
f5ed832
to
ccf47c2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
- Coverage 73.73% 73.72% -0.01%
==========================================
Files 70 70
Lines 7595 7604 +9
==========================================
+ Hits 5600 5606 +6
- Misses 1535 1537 +2
- Partials 460 461 +1
☔ View full report in Codecov by Sentry. |
kirugan
reviewed
Sep 19, 2023
omerfirmak
force-pushed
the
omerfirmak/panicing-service
branch
from
ccf47c2
to
11bc45f
Compare
kirugan
reviewed
Sep 19, 2023
omerfirmak
force-pushed
the
omerfirmak/panicing-service
branch
from
11bc45f
to
1b5fee2
Compare
omerfirmak
force-pushed
the
omerfirmak/panicing-service
branch
from
1b5fee2
to
07803e5
Compare
kirugan
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.