Recovery of cairo0 hash logic

[kirugan]

No description provided.

[omerfirmak]

To sanity check the changes here, can you enable Cairo0 class verification in syncing and start a fresh sync? You need to modify VerifyClassHashes

func VerifyClassHashes(classes map[felt.Felt]Class) error {
	for hash, class := range classes {
		cairo1Class, ok := class.(*Cairo1Class)
		// cairo0 classes are deprecated and hard to verify their hash, just ignore them
		if !ok {
			return nil
		}

		cHash := cairo1Class.Hash()
		if !cHash.Equal(&hash) {
			return fmt.Errorf("cannot verify class hash: calculated hash %v, received hash %v", cHash.String(), hash.String())
		}
	}
	return nil
}

[omerfirmak]

oh, that return nil below was a mistake :/ It should've been a continue

		cairo1Class, ok := class.(*Cairo1Class)
		// cairo0 classes are deprecated and hard to verify their hash, just ignore them
		if !ok {
			return nil
		}

[IronGauntlets]

LGTM

[codecov]

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (8c47775) 72.38% compared to head (c764e07) 72.89%.

Files	Patch %	Lines
p2p/starknet/block_bodies.go	0.00%	9 Missing ⚠️
adapters/core2sn/class.go	0.00%	5 Missing ⚠️
rpc/transaction.go	0.00%	3 Missing ⚠️
utils/zero_value.go	40.00%	2 Missing and 1 partial ⚠️
core/class.go	80.00%	1 Missing and 1 partial ⚠️
core/class_hash.go	83.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1470      +/-   ##
==========================================
+ Coverage   72.38%   72.89%   +0.51%     
==========================================
  Files          94       96       +2     
  Lines        9939     9943       +4     
==========================================
+ Hits         7194     7248      +54     
+ Misses       2208     2157      -51     
- Partials      537      538       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.