Allow for 10MB messages over grpc #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshklop
force-pushed
the
joshklop/grpc-msg-size
branch
from
af4c04d
to
7f961da
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
- Coverage 72.82% 72.75% -0.07%
==========================================
Files 96 96
Lines 9942 9947 +5
==========================================
- Hits 7240 7237 -3
- Misses 2163 2169 +6
- Partials 539 541 +2 ☔ View full report in Codecov by Sentry. |
omerfirmak
reviewed
Dec 4, 2023
omerfirmak
approved these changes
Dec 4, 2023
omerfirmak
force-pushed
the
joshklop/grpc-msg-size
branch
from
7f961da
to
5e5c3a3
Compare
Got an error message that looked something like this:
```
JunoStateGetCompiledClass failed to read class
{
"err": "rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5877256 vs. 4194304)"
}
github.com/NethermindEth/juno/vm.JunoStateGetCompiledClass/home/user/repos/juno/vm/state_reader.go:80
```
https://stackoverflow.com/questions/55362342/grpc-received-message-larger-than-max-8653851-vs-4194304
omerfirmak
force-pushed
the
joshklop/grpc-msg-size
branch
from
5e5c3a3
to
678e091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got an error message that looked something like this:
https://stackoverflow.com/questions/55362342/grpc-received-message-larger-than-max-8653851-vs-4194304