Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the genesis state #1530

Merged
merged 12 commits into from
Dec 8, 2023
Merged

Conversation

rianhughes
Copy link
Contributor

closes #1528

@rianhughes rianhughes changed the base branch from main to feature/sequencer December 7, 2023 09:38
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (acc9ac0) 72.90% compared to head (3f3edef) 72.64%.
Report is 4 commits behind head on feature/sequencer.

❗ Current head 3f3edef differs from pull request most recent head 1b06cd0. Consider uploading reports for the commit 1b06cd0 to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                  @@
##           feature/sequencer    #1530      +/-   ##
=====================================================
- Coverage              72.90%   72.64%   -0.27%     
=====================================================
  Files                     96       97       +1     
  Lines                   9948    10111     +163     
=====================================================
+ Hits                    7253     7345      +92     
- Misses                  2157     2208      +51     
- Partials                 538      558      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blockbuilder/genesisState.go Outdated Show resolved Hide resolved
blockbuilder/genesisState.go Outdated Show resolved Hide resolved
blockbuilder/genesisState.go Outdated Show resolved Hide resolved
Copy link
Contributor

@omerfirmak omerfirmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use some comments per field defining what they are supposed do.

@rianhughes rianhughes merged commit 38c672a into feature/sequencer Dec 8, 2023
3 of 4 checks passed
@rianhughes rianhughes deleted the rianhughes/seq-genesis-state branch December 8, 2023 15:57
@rianhughes rianhughes restored the rianhughes/seq-genesis-state branch December 8, 2023 15:58
@rianhughes rianhughes deleted the rianhughes/seq-genesis-state branch January 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequencer - genesis state definition and validation
3 participants