Calculate tx fee on Rust side only if actual_fee from blockifier is 0 #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1745 +/- ##
=======================================
Coverage 72.05% 72.06%
=======================================
Files 90 90
Lines 9724 9719 -5
=======================================
- Hits 7007 7004 -3
+ Misses 2192 2189 -3
- Partials 525 526 +1 ☔ View full report in Codecov by Sentry. |
IronGauntlets
approved these changes
Mar 14, 2024
kirugan
force-pushed
the
kirugan/fix-simulateTransactions
branch
from
c9ceb92
to
1837f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.