Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pebbledb to 1.1.0 #1769

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Update pebbledb to 1.1.0 #1769

merged 1 commit into from
Apr 9, 2024

Conversation

kirugan
Copy link
Contributor

@kirugan kirugan commented Mar 27, 2024

No description provided.

Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.23%. Comparing base (46102a1) to head (a58e101).

Files Patch % Lines
db/pebble/transaction.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
- Coverage   74.26%   74.23%   -0.03%     
==========================================
  Files          90       90              
  Lines        8203     8206       +3     
==========================================
  Hits         6092     6092              
- Misses       1587     1589       +2     
- Partials      524      525       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@IronGauntlets IronGauntlets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

If you haven't already it would be good to run ' make tidy`.

@stranger80 stranger80 added this to the v0.11.5 milestone Apr 8, 2024
@kirugan kirugan force-pushed the kirugan/update-pebble-1.1.0 branch from 8a36f3a to 4bb7430 Compare April 9, 2024 08:03
@kirugan kirugan force-pushed the kirugan/update-pebble-1.1.0 branch from 4bb7430 to a58e101 Compare April 9, 2024 09:38
@kirugan kirugan merged commit 84669c3 into main Apr 9, 2024
10 checks passed
@kirugan kirugan deleted the kirugan/update-pebble-1.1.0 branch April 9, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready For Release
Development

Successfully merging this pull request may close these issues.

5 participants