Replace Goerli2 network with Sepolia in the test TestEvents #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
+ Coverage 74.92% 75.04% +0.12%
==========================================
Files 96 96
Lines 8183 8183
==========================================
+ Hits 6131 6141 +10
+ Misses 1523 1517 -6
+ Partials 529 525 -4 ☔ View full report in Codecov by Sentry. |
|
The test data should come from the Sepolia network, not the Goerli network. See PR #1793 for more details |
rianhughes
approved these changes
Apr 5, 2024
|
Thank you, yes hopefully it will be pretty straight forward to update the TestEvents function in blockchain_test.go now. |
|
@stefanalfbo Great work, thank you for contributing to juno! ❤️ Please note that previous PR (#1768) has spread rpc handlers tests into several file. Thank you 🙏 |
stefanalfbo
force-pushed
the
chore/1790-TestEvents-Remove-Goerli
branch
from
256d322
to
5f00ba6
Compare
|
Thanks @pnowosie, it should now be rebased on main. |
pnowosie
force-pushed
the
chore/1790-TestEvents-Remove-Goerli
branch
from
5f00ba6
to
4f66d54
Compare
This includes making a copy of the necessary testdata used from the goerli2 directory to a new sepolia directory
pnowosie
force-pushed
the
chore/1790-TestEvents-Remove-Goerli
branch
from
4f66d54
to
e65be28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing the issue #1790, includes making a copy of the necessary testdata used from the
goerli2directory to a newsepoliadirectory.