-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Goerli2 network with Sepolia in the test TestEvents #1791
Replace Goerli2 network with Sepolia in the test TestEvents #1791
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
+ Coverage 74.92% 75.04% +0.12%
==========================================
Files 96 96
Lines 8183 8183
==========================================
+ Hits 6131 6141 +10
+ Misses 1523 1517 -6
+ Partials 529 525 -4 ☔ View full report in Codecov by Sentry. |
The test data should come from the Sepolia network, not the Goerli network. See PR #1793 for more details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. A nice follow on issue would be to update TestEvents in blockchain_test.go
Thank you, yes hopefully it will be pretty straight forward to update the TestEvents function in blockchain_test.go now. |
@stefanalfbo Great work, thank you for contributing to juno! ❤️ Please note that previous PR (#1768) has spread rpc handlers tests into several file. Thank you 🙏 |
256d322
to
5f00ba6
Compare
Thanks @pnowosie, it should now be rebased on main. |
5f00ba6
to
4f66d54
Compare
This includes making a copy of the necessary testdata used from the goerli2 directory to a new sepolia directory
4f66d54
to
e65be28
Compare
This PR is fixing the issue #1790, includes making a copy of the necessary testdata used from the
goerli2
directory to a newsepolia
directory.