Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to the network Sepolia in the TestClassV0 tests that are using the Goerli network #1808

Conversation

stefanalfbo
Copy link
Contributor

This PR is fixing the issue #1807.

New testdata for the classes has been fetched from the Sepolia network. All three tests has been using the Goerli network and the same class hashes, therefore all three tests are included in this PR,

  • sn2core_test.go - TestClassV0
  • class_test.go - TestClassV0Hash
  • feeder_test.go - TestClassV0

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.04%. Comparing base (a923c90) to head (ca9c709).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
- Coverage   75.11%   75.04%   -0.08%     
==========================================
  Files          96       96              
  Lines        8183     8183              
==========================================
- Hits         6147     6141       -6     
- Misses       1513     1515       +2     
- Partials      523      527       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnowosie pnowosie self-requested a review April 25, 2024 11:40
@pnowosie pnowosie force-pushed the chore/1807-TestClassV0-Remove-Goerli branch from e2df13e to f681e80 Compare April 26, 2024 11:57
@pnowosie pnowosie force-pushed the chore/1807-TestClassV0-Remove-Goerli branch from f681e80 to 964bbf7 Compare May 7, 2024 11:30
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… the Goerli network

New testdata for the classes has been fetched from the Sepolia network.
@pnowosie pnowosie force-pushed the chore/1807-TestClassV0-Remove-Goerli branch from 964bbf7 to ca9c709 Compare May 8, 2024 11:26
@pnowosie pnowosie merged commit 88b87fa into NethermindEth:main May 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants