Remove ForceFetchingTracesForBlocks feature #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1910 +/- ##
==========================================
+ Coverage 75.40% 75.43% +0.03%
==========================================
Files 97 97
Lines 8342 8341 -1
==========================================
+ Hits 6290 6292 +2
+ Misses 1522 1520 -2
+ Partials 530 529 -1 ☔ View full report in Codecov by Sentry. |
wojciechos
force-pushed
the
wojciechos/remove_ForceFetchingTracesForBlocks
branch
from
ca7eefa
to
bda6e61
Compare
kirugan
approved these changes
Jun 25, 2024
rianhughes
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ForceFetchingTracesForBlockslogic has been removed. Traces are now fallback for all blocks up to Starknet version v0.13.1, making the previous logic redundant.