Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snap/merge range and proof #1913
Snap/merge range and proof #1913
Changes from 1 commit
5cd826f
3ecb395
d2fe491
2cd3157
3603e28
d8f5811
40a3d04
fb6c899
07e99f5
c0b933a
529aef2
ca360e9
fdf6af2
9f9f2fe
bad7267
92a98df
727801b
b4ae2b6
a123730
d249186
21f9453
2d7c6e8
46c7b8a
0bb2edc
ce20e08
ec2f917
dd21cc0
571eb6e
b614c2e
89cf035
20e2aa0
faa0884
59440ac
35b46d0
cb26dd7
1454ad5
d4b4232
4f4940f
909914d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 7 in core/trie/key.go
Check failure on line 8 in core/trie/key.go
Check failure on line 9 in core/trie/key.go
Check failure on line 4 in core/trie/snap_support.go
Check warning on line 17 in core/trie/snap_support.go
core/trie/snap_support.go#L17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean that the left proof is for the start query, and not the actual leaf? I thought the left proof would be for the first key/leaf in the range?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually no. Its a very edge.. edge case. Can't remember at the top of my head why.
Check warning on line 30 in core/trie/snap_support.go
core/trie/snap_support.go#L30
Check failure on line 37 in core/trie/snap_support.go
Check warning on line 44 in core/trie/snap_support.go
core/trie/snap_support.go#L44
Check failure on line 60 in core/trie/snap_support.go
Check failure on line 71 in core/trie/snap_support.go
Check warning on line 73 in core/trie/snap_support.go
core/trie/snap_support.go#L73
Check failure on line 77 in core/trie/snap_support.go
Check warning on line 79 in core/trie/snap_support.go
core/trie/snap_support.go#L79
Check warning on line 85 in core/trie/snap_support.go
core/trie/snap_support.go#L85
Check warning on line 104 in core/trie/snap_support.go
core/trie/snap_support.go#L104
Check failure on line 108 in core/trie/snap_support.go
Check failure on line 125 in core/trie/snap_support.go
Check warning on line 151 in core/trie/snap_support.go
core/trie/snap_support.go#L151
Check warning on line 160 in core/trie/snap_support.go
core/trie/snap_support.go#L160
Check warning on line 167 in core/trie/snap_support.go
core/trie/snap_support.go#L167