Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General function for commitement parallel processing #2169

Merged
merged 14 commits into from
Oct 1, 2024

Conversation

AnkushinDaniil
Copy link
Contributor

@AnkushinDaniil AnkushinDaniil commented Sep 23, 2024

Add a generic calculateCommitment function and use it to calculate the commitment

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (6b683d8) to head (26da3eb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/transaction.go 96.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2169      +/-   ##
==========================================
+ Coverage   78.47%   78.62%   +0.14%     
==========================================
  Files         100      100              
  Lines        9240     9191      -49     
==========================================
- Hits         7251     7226      -25     
+ Misses       1351     1339      -12     
+ Partials      638      626      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnkushinDaniil AnkushinDaniil force-pushed the daniil/general-function-for-receipt-parallel-processing branch from 851ddd3 to 39a058c Compare September 23, 2024 11:29
@AnkushinDaniil AnkushinDaniil marked this pull request as draft September 23, 2024 11:32
@AnkushinDaniil AnkushinDaniil marked this pull request as ready for review September 23, 2024 11:45
@AnkushinDaniil AnkushinDaniil changed the title General function for receipt parallel processing General function for commitement parallel processing Sep 23, 2024
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/general-function-for-receipt-parallel-processing branch 6 times, most recently from dec65f3 to 16f503e Compare September 25, 2024 13:21
@pnowosie pnowosie self-requested a review September 26, 2024 11:15
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

core/transaction.go Outdated Show resolved Hide resolved
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/general-function-for-receipt-parallel-processing branch 2 times, most recently from 29188d4 to b1cd568 Compare September 30, 2024 08:16
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/general-function-for-receipt-parallel-processing branch from b1cd568 to 66a1b95 Compare September 30, 2024 11:19
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/general-function-for-receipt-parallel-processing branch from 66a1b95 to 96f0f47 Compare October 1, 2024 08:10
@kirugan kirugan enabled auto-merge (squash) October 1, 2024 20:34
@kirugan kirugan merged commit 0c0700c into main Oct 1, 2024
10 checks passed
@kirugan kirugan deleted the daniil/general-function-for-receipt-parallel-processing branch October 1, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants