memTransaction: create key strings without hex encoding #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirugan
requested review from
IronGauntlets,
joshklop,
omerfirmak,
jelilat and
wojciechos
as code owners
IronGauntlets
approved these changes
Jun 2, 2023
joshklop
approved these changes
Jun 2, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
=======================================
Coverage 75.70% 75.70%
=======================================
Files 44 44
Lines 4408 4408
=======================================
Hits 3337 3337
Misses 849 849
Partials 222 222
☔ View full report in Codecov by Sentry. |
omerfirmak
force-pushed
the
kirugan/simplify-keys-in-memTransaction
branch
from
cb65e0c
to
45f362d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero bytes in a string are ok -> https://go.dev/play/p/nmcQf4vaXIL