-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lmbdx integration as key-value pair database #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new interface in DB
tkstanczak
requested changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code coverage with tests below previous value.
AntiD2ta
force-pushed
the
core/db_integration
branch
from
March 1, 2022 20:33
9737006
to
6efc2a9
Compare
tkstanczak
approved these changes
Mar 2, 2022
IronGauntlets
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Add interfaces for Database * Add mdbx to go.{mod.sum} * Modify interface * Implementation of database interface * Add tests files for database * Add test for add key and solve small errors * Solve small errors in database tests * Add sirupsen/log for logging to app * Add instructions for log in README * Use logrus as logging in main * Add debugging for encoding of chain ID * Add logs for sn_keccak * Add method for get the number of records inside DB interface * [log] Add comments and logs and restructuration for implementation of new interface in DB * Change name for kv-database initializer * Add more logs to database and solve small typos * Add first set of tests for database * Remove unused lines * Update tests for database to receive db path as params * Add benchmarking for databases * Set log level to error and debug in tests * Add new functionalities to init * Add comments for database_test * Improve code-coverage for database tests * Add zap to go modules as new logging library * Create using Singleton pattern logger for app using zap * Change in main new logging with zap for logrus * Remove logrus from go mod * Change zap for logrus in internal code * Add docs for logging in readme using zap * Update implementations to use With * change logs from logrus to zap * Modify comment in database log * Add example about how to store in database * Update image of the logs * Add image to README * Add image to README * Update image of the logs * Remove unused mutex in database * Add courtney for code-coverage * Solve code coverage issues * Fix workflow to use courtney for code-coverage * Change tests layout * Update makefile courtney installation * Add go get in makefile for project * Add gopath to command * Add gopath initialization in makefile * Add initialization for gopath in makefile * Change to install latest * Add DemerzelSolutions fork as base for courtney coverage * Install courtney using cli instead package * Add go get to deps install * Set .out instead .txt as coverage output * Add workflow_dispatch trigger to juno-test workflow Co-authored-by: AntiD2ta <mtpotro41@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #24
Changes:
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??