Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmbdx integration as key-value pair database #80

Merged
merged 59 commits into from
Mar 2, 2022
Merged

Conversation

stdevMac
Copy link
Member

Fixes | Closes | Resolves #24

Changes:

  • Add integrations for libmx using mdbx binding

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Copy link
Member

@tkstanczak tkstanczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code coverage with tests below previous value.

@AntiD2ta AntiD2ta closed this Mar 1, 2022
@AntiD2ta AntiD2ta reopened this Mar 1, 2022
@tkstanczak tkstanczak merged commit ab8f71d into main Mar 2, 2022
@stdevMac stdevMac deleted the core/db_integration branch March 17, 2022 22:02
IronGauntlets pushed a commit that referenced this pull request Aug 18, 2022
* Add interfaces for Database

* Add mdbx to go.{mod.sum}

* Modify interface

* Implementation of database interface

* Add tests files for database

* Add test for add key and solve small errors

* Solve small errors in database tests

* Add sirupsen/log for logging to app

* Add instructions for log in README

* Use logrus as logging in main

* Add debugging for encoding of chain ID

* Add logs for sn_keccak

* Add method for get the number of records inside DB interface

* [log] Add comments and logs and restructuration for implementation of new interface in DB

* Change name for kv-database initializer

* Add more logs to database and solve small typos

* Add first set of tests for database

* Remove unused lines

* Update tests for database to receive db path as params

* Add benchmarking for databases

* Set log level to error and debug in tests

* Add new functionalities to init

* Add comments for database_test

* Improve code-coverage for database tests

* Add zap to go modules as new logging library

* Create using Singleton pattern logger for app using zap

* Change in main new logging with zap for logrus

* Remove logrus from go mod

* Change zap for logrus in internal code

* Add docs for logging in readme using zap

* Update implementations to use With

* change logs from logrus to zap

* Modify comment in database log

* Add example about how to store in database

* Update image of the logs

* Add image to README

* Add image to README

* Update image of the logs

* Remove unused mutex in database

* Add courtney for code-coverage

* Solve code coverage issues

* Fix workflow to use courtney for code-coverage

* Change tests layout

* Update makefile courtney installation

* Add go get in makefile for project

* Add gopath to command

* Add gopath initialization in makefile

* Add initialization for gopath in makefile

* Change to install latest

* Add DemerzelSolutions fork as base for courtney coverage

* Install courtney using cli instead package

* Add go get to deps install

* Set .out instead .txt as coverage output

* Add workflow_dispatch trigger to juno-test workflow

Co-authored-by: AntiD2ta <mtpotro41@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup mdbx storage layer
4 participants