Duplicate iterator buffers #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
requested review from
a team,
IronGauntlets and
joshklop
and removed request for
a team
omerfirmak
force-pushed
the
omerfirmak/it-buffers
branch
from
61bd4ca
to
4b2d92f
Compare
IronGauntlets
approved these changes
Jun 15, 2023
joshklop
approved these changes
Jun 15, 2023
omerfirmak
force-pushed
the
omerfirmak/it-buffers
branch
from
4b2d92f
to
67bda3e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
==========================================
+ Coverage 72.96% 73.06% +0.09%
==========================================
Files 54 54
Lines 5241 5253 +12
==========================================
+ Hits 3824 3838 +14
+ Misses 1109 1107 -2
Partials 308 308
☔ View full report in Codecov by Sentry. |
wojciechos
approved these changes
Jun 15, 2023
The slice that pebble.Iterator returns for Key() and Value() requests are owned by the iterator. So it can be reused or garbage collected anytime. We should make sure that we own those slices by copying the data first
omerfirmak
force-pushed
the
omerfirmak/it-buffers
branch
from
67bda3e
to
07afa95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slice that pebble.Iterator returns for Key() and Value() requests are owned by the iterator. So it can be reused or garbage collected anytime.
We should make sure that we own those slices by copying the data first