-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add juno snapshot in readme #873
Conversation
fa5fd70
to
d65530c
Compare
edit: just saw that version is mentioned in the table. Never mind :) Are these snapshots for the main branch or v0.3.1? We won't want them in the readme if users can't use them with latest release. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 72.63% 72.51% -0.12%
==========================================
Files 56 56
Lines 5942 5942
==========================================
- Hits 4316 4309 -7
- Misses 1260 1265 +5
- Partials 366 368 +2 ☔ View full report in Codecov by Sentry. |
d65530c
to
0aa0feb
Compare
Actually, it's a good point, I marked it as v0.3.1 but indeed it's snapshot from current main which gonna be v0.4.0. I changed Version in readme to 0.4.0 and I guess we should wait with merging this PR until release to avoid users question, as we have with |
README.md
Outdated
|
||
| Network | Version | Block | Download Link | | ||
| ------- | ------- | ----- | ------------- | | ||
| mainnet | v0.4.0 | 94260 | [juno_mainnet_94260.tar](https://juno-snapshot.s3.us-east-2.amazonaws.com/mainnet/juno-mainnet-94260.tar) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we include the file size in the tables as well?
0aa0feb
to
e1c930d
Compare
c1d36be
to
99a992e
Compare
1214306
to
e61d0d9
Compare
e61d0d9
to
af85cc1
Compare
No description provided.