Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add juno snapshot in readme #873

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add juno snapshot in readme #873

merged 1 commit into from
Jul 10, 2023

Conversation

wojciechos
Copy link
Contributor

No description provided.

@joshklop
Copy link
Contributor

joshklop commented Jun 30, 2023

edit: just saw that version is mentioned in the table. Never mind :)

Are these snapshots for the main branch or v0.3.1? We won't want them in the readme if users can't use them with latest release.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (99a992e) 72.63% compared to head (c1d36be) 72.51%.

❗ Current head c1d36be differs from pull request most recent head af85cc1. Consider uploading reports for the commit af85cc1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   72.63%   72.51%   -0.12%     
==========================================
  Files          56       56              
  Lines        5942     5942              
==========================================
- Hits         4316     4309       -7     
- Misses       1260     1265       +5     
- Partials      366      368       +2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wojciechos
Copy link
Contributor Author

wojciechos commented Jun 30, 2023

edit: just saw that version is mentioned in the table. Never mind :)

Are these snapshots for the main branch or v0.3.1? We won't want them in the readme if users can't use them with latest release.

Actually, it's a good point, I marked it as v0.3.1 but indeed it's snapshot from current main which gonna be v0.4.0. I changed Version in readme to 0.4.0 and I guess we should wait with merging this PR until release to avoid users question, as we have with --eth-node now

@wojciechos wojciechos marked this pull request as draft June 30, 2023 15:49
README.md Outdated

| Network | Version | Block | Download Link |
| ------- | ------- | ----- | ------------- |
| mainnet | v0.4.0 | 94260 | [juno_mainnet_94260.tar](https://juno-snapshot.s3.us-east-2.amazonaws.com/mainnet/juno-mainnet-94260.tar) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we include the file size in the tables as well?

@wojciechos wojciechos closed this Jul 10, 2023
@wojciechos wojciechos reopened this Jul 10, 2023
@wojciechos wojciechos marked this pull request as ready for review July 10, 2023 15:32
@omerfirmak omerfirmak merged commit 017cfbe into main Jul 10, 2023
6 checks passed
@omerfirmak omerfirmak deleted the wojciechos/juno_snapshot branch July 10, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants