Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix providing juno version for docker images #912

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

wojciechos
Copy link
Contributor

@wojciechos wojciechos commented Jul 13, 2023

This PR resolves an issue with the juno_version method for our Docker images.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (d35aef8) 72.74% compared to head (6430a5a) 72.77%.

❗ Current head 6430a5a differs from pull request most recent head 62bd2a9. Consider uploading reports for the commit 62bd2a9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
+ Coverage   72.74%   72.77%   +0.03%     
==========================================
  Files          58       58              
  Lines        6047     6047              
==========================================
+ Hits         4399     4401       +2     
+ Misses       1278     1276       -2     
  Partials      370      370              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wojciechos wojciechos force-pushed the wojciechos/docker_juno_version branch 2 times, most recently from 6430a5a to 80430df Compare July 13, 2023 08:59
@wojciechos wojciechos force-pushed the wojciechos/docker_juno_version branch from 80430df to 62bd2a9 Compare July 13, 2023 09:00
@wojciechos wojciechos marked this pull request as ready for review July 13, 2023 09:00
@wojciechos wojciechos changed the title Add git in Dockerfile to get juno_version Fix providing juno version for docker images Jul 13, 2023
@omerfirmak omerfirmak merged commit 90f99ef into main Jul 13, 2023
8 checks passed
@omerfirmak omerfirmak deleted the wojciechos/docker_juno_version branch July 13, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants