Remove ReadDuration websocket connection param #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshklop
requested review from
a team and
IronGauntlets
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
==========================================
+ Coverage 73.23% 73.28% +0.04%
==========================================
Files 59 59
Lines 6304 6299 -5
==========================================
- Hits 4617 4616 -1
+ Misses 1303 1301 -2
+ Partials 384 382 -2
☔ View full report in Codecov by Sentry. |
omerfirmak
approved these changes
Jul 25, 2023
omerfirmak
force-pushed
the
joshklop/read-duration
branch
from
2d613ba
to
e8c85fb
Compare
joshklop
force-pushed
the
joshklop/read-duration
branch
2 times, most recently
from
42d7bab
to
43d9a40
Compare
Disconnects clients automatically after 30 seconds if there is no request. This is problematic for subscriptions, where a client may never make more than one request even if multiple responses are sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disconnects clients automatically after 30 seconds if there is no request. This is problematic for subscriptions, where a client may never make more than one request even if multiple responses are sent.