Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust ErrInsufficientMaxFee response message to latest starknet spec #964

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

wojciechos
Copy link
Contributor

@wojciechos wojciechos requested review from a team and IronGauntlets and removed request for a team July 27, 2023 15:12
@wojciechos wojciechos force-pushed the wojciechos/rpc_response branch 3 times, most recently from 2043d05 to 5a02f46 Compare July 27, 2023 15:19
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (6e5984f) 73.56% compared to head (5743c94) 73.67%.

❗ Current head 5743c94 differs from pull request most recent head c3d6a8f. Consider uploading reports for the commit c3d6a8f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   73.56%   73.67%   +0.11%     
==========================================
  Files          59       59              
  Lines        6359     6359              
==========================================
+ Hits         4678     4685       +7     
+ Misses       1281     1277       -4     
+ Partials      400      397       -3     
Files Changed Coverage Δ
rpc/handlers.go 77.59% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rpc/handlers.go Outdated Show resolved Hide resolved
@omerfirmak omerfirmak merged commit 457fc84 into main Jul 27, 2023
4 of 5 checks passed
@omerfirmak omerfirmak deleted the wojciechos/rpc_response branch July 27, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants