wip : sierra hashing logic broken

NethermindEth · Oct 2, 2023 · e7d0c58 · e7d0c58
1 parent 7def09e
commit e7d0c58
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/artifacts/hello_starknet_compiled.sierra.json b/artifacts/hello_starknet_compiled.sierra.json
@@ -358,5 +358,5 @@
     "L1_HANDLER": [],
     "CONSTRUCTOR": []
   },
-  "abi": "[{\"type\":\"function\",\"name\":\"increase_balance\",\"inputs\":[{\"name\":\"amount\",\"type\":\"core::felt252\"}],\"outputs\":[],\"state_mutability\":\"external\"},{\"type\":\"function\",\"name\":\"get_balance\",\"inputs\":[],\"outputs\":[{\"type\":\"core::felt252\"}],\"state_mutability\":\"view\"},{\"type\":\"event\",\"name\":\"hello_starknet::hello_starknet::hello_starknet::Event\",\"kind\":\"enum\",\"variants\":[]}]"
+  "abi": "[{\"type\": \"function\", \"name\": \"increase_balance\", \"inputs\": [{\"name\": \"amount\", \"type\": \"core::felt252\"}], \"outputs\": [], \"state_mutability\": \"external\"}, {\"type\": \"function\", \"name\": \"get_balance\", \"inputs\": [], \"outputs\": [{\"type\": \"core::felt252\"}], \"state_mutability\": \"view\"}, {\"type\": \"event\", \"name\": \"hello_starknet::hello_starknet::hello_starknet::Event\", \"kind\": \"enum\", \"variants\": []}]"
 }
diff --git a/hash/hash.go b/hash/hash.go
@@ -1,6 +1,8 @@
 package hash
 
 import (
+	"fmt"
+
 	"github.com/NethermindEth/juno/core/felt"
 	starknetgo "github.com/NethermindEth/starknet.go"
 	newcontract "github.com/NethermindEth/starknet.go/newcontracts"
@@ -47,7 +49,8 @@ func CalculateTransactionHashCommon(
 }
 
 func ClassHash(contract rpc.ContractClass) (*felt.Felt, error) {
-	//https://docs.starknet.io/documentation/architecture_and_concepts/Smart_Contracts/class-hash/
+	// https://docs.starknet.io/documentation/architecture_and_concepts/Smart_Contracts/class-hash/
+	// https://github.com/starkware-libs/cairo-lang/blob/7712b21fc3b1cb02321a58d0c0579f5370147a8b/src/starkware/starknet/core/os/contracts.cairo#L47
 
 	Version := "CONTRACT_CLASS_V" + contract.ContractClassVersion
 	ContractClassVersionHash := new(felt.Felt).SetBytes([]byte(Version))
@@ -64,6 +67,7 @@ func ClassHash(contract rpc.ContractClass) (*felt.Felt, error) {
 	if err != nil {
 		return nil, err
 	}
+	// The ABI Bytes seem to match, but the hash does not
 	ABI := new(felt.Felt).SetBytes([]byte(contract.ABI))
 	ABIHash, err := ComputeHashOnElementsFelt([]*felt.Felt{ABI})
 	if err != nil {
@@ -74,6 +78,13 @@ func ClassHash(contract rpc.ContractClass) (*felt.Felt, error) {
 		return nil, err
 	}
 
+	fmt.Println("ContractClassVersionHash", ContractClassVersionHash) // Correct
+	fmt.Println("ExternalHash", ExternalHash)                         // Incorrect
+	fmt.Println("L1HandleHash", L1HandleHash)                         // Incorrect
+	fmt.Println("ConstructorHash", ConstructorHash)                   // Incorrect
+	fmt.Println("newABIHash", ABIHash)                                // Incorrect
+	fmt.Println("SierraProgamHash", SierraProgamHash)                 // Incorrect
+
 	// https://docs.starknet.io/documentation/architecture_and_concepts/Network_Architecture/transactions/#deploy_account_hash_calculation
 	return ComputeHashOnElementsFelt(
 		[]*felt.Felt{