Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #363

Merged
merged 4 commits into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ to them. In particular, you will find:

- A link to the OZ v0.3.2 preset account you might not want to use
- A link to the OZ v0.4.0b preset account you might not want to use
- A link to the Argentlabs/Ledger/Catridge plugin account, you might not want
- A link to the Argentlabs/Ledger/Cartridge plugin account, you might not want
to use either
- The implementation of the `YeaSayer` plugin that always agree on the
transactions and the implementation of the SessionKey plugin that comes with
Expand All @@ -22,7 +22,7 @@ shows how to build those contracts. You should:
- install cairo v0.9.1 with Python 3.9 and run the following commands

```shell
# this command reset the OZ submodule to a version that was providing the v0
# this command resets the OZ submodule to a version that was providing the v0
# account. It is using the cairo v0.9 syntax
make v0 -f MakefileV0
# compile the contracts
Expand Down
2 changes: 1 addition & 1 deletion docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Requests](https://github.com/NethermindEth/starknet.go/pulls) for review by the

We recommend the following work-flow for contributors:

1. **Find an issue** to work on and use comments to communciate your intentions and ask questions.
1. **Find an issue** to work on and use comments to communicate your intentions and ask questions.
2. **Work in a feature branch** of your personal fork (github.com/YOUR_NAME/starknet.go) of the main repository (github.com/NethermindEth/starknet.go).
3. After you have implemented or resolved the issue, **create a pull-request** to merge your changes in the main repository
4. Wait for the repository maintainers to **review your changes** to ensure the issue is addressed.
Expand Down
12 changes: 6 additions & 6 deletions docs/developers.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ know them and you can contribute to the associated projects:
is a project that lists all the existing API and provides some examples
of how to use them.
- There is no true specification of the API we are aware of, however the
implementationis opensource and can be read from the
implementation is opensource and can be read from the
starkware-libs/cairo-lang
[api/gateway directory](https://github.com/starkware-libs/cairo-lang/tree/master/src/starkware/starknet/services/api/gateway)
- Starknet `openrpc` specification is available in the
Expand All @@ -58,16 +58,16 @@ resources available, check:

- [a set of examples](https://github.com/eqlabs/pathfinder/blob/main/crates/pathfinder/rpc_examples.sh)
from the eqlabs/pathfinder project that provides RPC tests with the project.
Note that the [go-ethereum] implementation of openrpc only support positional
Note that the [go-ethereum] implementation of openrpc only supports positional
arguments and, some of these examples must be changed into positional calls.
- `#🦦| starknet.go` channel in the discord from Starknet.

## How to interact with accounts?

An important part of interacting with Starknet consists in interacting
accounts. The reason is that you need go through an account to run transactions,
accounts. The reason is that you need to go through an account to run transactions,
including to create a contract from a class. That is why you should understand
what is an account is and how to interact with it.
what an account is and how to interact with it.

The devil living in the details, there are specificities associated with
account implementations. For instance, you might find that one account does not
Expand All @@ -77,7 +77,7 @@ support the same signature as an other. To start with account, read:
- [Starknet Account Abstraction Model - Part 2](https://community.starknet.io/t/starknet-account-abstraction-model-part-2/839)
- [Learn how to build and deploy Starknet Accounts](https://github.com/starknet-edu/starknet-accounts)
and the companion [Starknet workshop](https://www.youtube.com/watch?v=51Qb3TLpNro)
- Openzeppelin Cairo contracts that includes an account
- Openzeppelin Cairo contracts that include an account
[implementation](https://github.com/OpenZeppelin/cairo-contracts/tree/main/src/openzeppelin/account)
- The argent-x contract
[implementation](https://github.com/argentlabs/argent-contracts-starknet)
Expand All @@ -94,7 +94,7 @@ integration tests and use tools to capture paylods:
mode allows to create a reverse proxy to the API and capture the workload. You
then should be able to run transaction with tools like the Starknet CLI and
better understand that is happening under the hood.
- If you interact from Dapps, like Voyager and want to unrdestand how the
- If you interact from Dapps, like Voyager and want to understand how the
interactions with contract are happening, you can use:
- Chrome [debugging extensions](https://developer.chrome.com/docs/extensions/mv3/tut_debugging/)
- Firefox [debugging extensions](https://extensionworkshop.com/documentation/develop/debugging/)
Expand Down
2 changes: 1 addition & 1 deletion examples/deployAccount/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

This example uses a pre-existing contract on the goerli network to deploy a new account contract. To successfuly run this example, you will need: 1) a goerli endpoint, and 2) to fund the precomputed address.
This example uses a pre-existing contract on the goerli network to deploy a new account contract. To successfully run this example, you will need: 1) a goerli endpoint, and 2) to fund the precomputed address.

Steps:
1. Rename the ".env.template" file to ".env.testnet"
Expand Down