Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

CI to build and push docker image on release #1054

Merged
merged 9 commits into from
May 25, 2023
Merged

CI to build and push docker image on release #1054

merged 9 commits into from
May 25, 2023

Conversation

cicr99
Copy link
Contributor

@cicr99 cicr99 commented May 17, 2023

Fixes #1050

@cicr99 cicr99 marked this pull request as ready for review May 19, 2023 13:26
@cicr99
unify publish pacakge to npmjs and docker image in the same workflow
c5f86c9 
use tag_name instead of release tag

remove default options
temyurchenko
temyurchenko approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@temyurchenko temyurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems perfectly reasonable, but I'm not particularly an expert on Docker infrastructure

cicr99 and others added 2 commits May 25, 2023 07:30
@cicr99 @piwonskp
Modify job name for building docker image
31695da 
Co-authored-by: Piotr Piwoński <piwonskp@gmail.com>
@cicr99 @piwonskp
Modify job name for building npm package
2983660 
Co-authored-by: Piotr Piwoński <piwonskp@gmail.com>
@cicr99 cicr99 merged commit 5584139 into develop May 25, 2023
7 checks passed
@cicr99 cicr99 deleted the docker_build_and_push branch May 25, 2023 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@temyurchenko temyurchenko temyurchenko approved these changes

@piwonskp piwonskp piwonskp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI to push image to dockerhub
3 participants
@cicr99 @piwonskp @temyurchenko