Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.9.0 #379

Merged
merged 15 commits into from
Nov 13, 2020
Merged

Release v0.9.0 #379

merged 15 commits into from
Nov 13, 2020

Conversation

dizcza
Copy link
Member

@dizcza dizcza commented Nov 5, 2020

No description provided.

@dizcza dizcza marked this pull request as draft November 5, 2020 15:49
@coveralls
Copy link
Collaborator

coveralls commented Nov 5, 2020

Coverage Status

Coverage decreased (-0.008%) to 89.914% when pulling e856659 on INM-6:release/090 into 366cd7c on NeuralEnsemble:master.

@apdavison
Copy link
Member

Hi @dizcza we are ready to release Neo 0.9.0 from the master branch, but before doing so I wanted to check with you that the current Neo master doesn't break anything in Elephant.

@dizcza
Copy link
Member Author

dizcza commented Nov 10, 2020

Hi @apdavison
2 tests fail in test_neo_tools.py with the latest neo master branch:
test__extract_neo_attrs__spiketrain_parents_childfirst_array
test__extract_neo_attrs__spiketrain_parents_parentfirst_array
These tests are 6 years old. I'm doing a video recording right now, I'll look into the issues in a few hours. Help is appreciated since I already see that the quality of test code is not that great and + it's neo tools, in which I rarely look, so it could be hard for me to realize what is going on.
Maybe @JuliaSprenger have insights?

@samuelgarcia
Copy link

The test you mention use ChannelIndex and Units.
I think you should remove theses classes in your tests suite.
But this should still work at least for neo 0.9

@dizcza
Copy link
Member Author

dizcza commented Nov 10, 2020

Are ChannelIndex and Units deprecated now?

@apdavison
Copy link
Member

yes - for more information see https://neo.readthedocs.io/en/latest/releases/0.9.0.html

@JuliaSprenger
Copy link
Member

Yes, they are deprecated and not used any more by the IOs. For compatiblity reasons the classes will still be included in version 0.9.0, but should not be used any more.

@dizcza
Copy link
Member Author

dizcza commented Nov 10, 2020

I removed ChannelIndex-related tests from neo utils. Now it works.
Thanks!

@dizcza dizcza marked this pull request as ready for review November 13, 2020 10:18
@dizcza dizcza merged commit 8e465fd into NeuralEnsemble:master Nov 13, 2020
@dizcza dizcza deleted the release/090 branch November 13, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants