Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak #28

Merged
merged 1 commit into from Jan 21, 2024
Merged

Fix memory leak #28

merged 1 commit into from Jan 21, 2024

Conversation

notaLonelyDay
Copy link
Contributor

fix memory leak in LaunchActivity when onDestroy() method from LaunchActivity called but onFragmentDestroy() from DialogsActivity doesn't called and this causes a memory leak

copy: DrKLO/Telegram#1797

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Bug fix

PR Summary: The pull request introduces a call to clearFragments() in the onDestroy() method of LaunchActivity to address a memory leak issue.

Decision: Comment

📝 Type: 'Bug fix' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • The change appears to address the memory leak issue described. However, it would be beneficial to ensure that the clearFragments() method is robust, handling all fragment states correctly and not throwing any unchecked exceptions.
  • It's important to verify that the addition of clearFragments() does not introduce any new issues, such as improper resource release or side effects that could affect the application's stability.
  • Given the critical nature of the onDestroy() method, a thorough review of the clearFragments() implementation is recommended to confirm that it safely cleans up without causing any adverse effects.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@omg-xtao omg-xtao merged commit f356804 into NextAlone:dev Jan 21, 2024
LiuYi0526 pushed a commit to LiuYi0526/Nagram that referenced this pull request Jan 21, 2024
@NextAlone NextAlone mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants