Some improvements to External Sticker Cache #32
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces several enhancements to the External Sticker Cache feature, including the addition of automatic synchronization toggles, manual one-click synchronization and deletion buttons for all caches, and new menu items in StickerActivity for refreshing and deleting. It also improves the use of NotificationCenter for triggering auto-sync and adds independent grouping for settings items. Additionally, the PR includes improvements to the Chinese names of settings items to enhance their appearance.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Verify that the removal of 'ExternalStickerCacheHelper.cacheStickers()' calls does not affect the expected behavior of sticker caching and loading, as this could introduce regressions.
- Ensure that the new settings and features introduced are reflected in the user interface and are accessible to the user as expected.
- Review the changes to ensure that the new features integrate well with the existing codebase and do not disrupt any existing functionality.
- Consider providing a brief documentation or comments within the code to explain the purpose and usage of the new features and settings for future maintainability.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
TMessagesProj/src/main/java/org/telegram/ui/Components/StickerMasksAlert.java
Show resolved
Hide resolved
TMessagesProj/src/main/java/org/telegram/ui/StickersActivity.java
Outdated
Show resolved
Hide resolved
add: 自动同步开关
add: 手动一键同步和删除所有缓存的按钮
add: StickersActivity 中的刷新和删除菜单项
add: 支持使用 short name 作为目录名
improve: 使用 Telegram 的 NotificationCenter 来触发自动同步
improve: 为设置项添加独立分组
improve: 改了一下设置项的中文名让它更好看
improve: 自动创建 .nomedia 以避免相册惨剧
fix:
ExternalStickerCacheHelper.caching值变为 true 后不会自动改回 false