Perposal for some changes to dpd-fileupload #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purposal for dpd-fileupload
|
I have tested this locally and all works well, but travis is failing, so I will look over the tests when I have time... |
|
Hi @tenowg Give me some time to review this. In the meanwhile, can you make the tests pass? |
|
I will have a few hours to work on this in the next few days... But I have been playing around with this more than I should be... I will push what I have to my organization, and I will attempt to make all tests pass... I believe the fault is the permissions section |
Making tests work, and other misc stuff...
| if (!this.config.properties || !this.config.directory || !this.config.fullDirectory) { | ||
| // We will no longer need a config.properties | ||
| // This 'should' be first run only, and shouldn't need to be saved... | ||
| if (!this.config.directory || !this.config.fullDirectory) { |
There was a problem hiding this comment.
will be removing this part all together shortly... config will be set with this.config.blah || process.env.blah || "default"... saving the need for a automatic forced save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a few changes to how this Module/Collection works on a base level, creating a config page, implementing a ability to require a login to write a file, implementing Upload event, implemented an extension for dashboard so data shows correctly.
If you want editable properties, you can add a properties.html/properties.js copied from collection/dashboard and modify them for this module.
As a caveat to Module creation... I created the modules while using npm link, __dirname was incorrect, so I used a directory based off config location.