Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Fixed bug when logging discriminator loss for tensorboard in GAN application #475

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

javierbg
Copy link
Contributor

Status

READY

Description

There was a bug when logging the Discrimiantor loss in the GAN application: the Generator loss would be logged instead. This fixes that.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Todos

  • Tests
  • Documentation

I ran the tests before and after the change, and the same error came up:

.2020-01-16 13:44:12.961729: F ./tensorflow/core/util/mkl_util.h:636] Check failed: dims == sizes.size() (5 vs. 4)

I'm very confident that this minor change doesn't break anything and I was able to check that it works in my own code.

Impacted Areas in Application

List general components of the application that this PR will affect:

  • niftynet.application.GANApplication

@wyli wyli merged commit 7421b01 into NifTK:dev Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants