Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MaterialMesh2dBundle with ColorMaterial #224

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Conversation

Nilirad
Copy link
Owner

@Nilirad Nilirad commented Sep 9, 2023

Since asset V2 came, I decided to swap the custom shape material with the standard color material.

This is still a draft, since for some reason the green channel for vertex coloring gets completely ignored (e.g. white appears as magenta, or cyan appears as blue).

@Nilirad
Copy link
Owner Author

Nilirad commented Sep 10, 2023

Thanks to @rparrett for finding the bug 🥳

@Nilirad Nilirad marked this pull request as ready for review September 10, 2023 16:48
@Nilirad Nilirad merged commit 77999ac into bevy-main Sep 10, 2023
5 checks passed
@Nilirad Nilirad deleted the color-material branch September 10, 2023 16:48
Nilirad added a commit that referenced this pull request Nov 6, 2023
* Suggest to use `cargo add` in README.md (#222)

* Use `SpatialBundle` (#221)

* Use `configure_sets` API (#223)

* Use `MaterialMesh2dBundle` with `ColorMaterial` (#224)

* Use `MaterialMesh2dBundle` with `ColorMaterial`

* clippy

* Fix green channel filtering bug

* Clippy again

* Update svgtypes to 0.12

* Update Bevy to 0.12

* Update to version 0.10.0

* Use diff-friendly markdown column format

---------

Co-authored-by: Federico Rinaldi <gisquerin@gmail.com>
Nilirad added a commit that referenced this pull request Feb 19, 2024
* Use GitHub Actions config from master branch

* Fix formatting

* Fix deprecation warnings on add_plugin

Fix CI (#218)

Fix shader (#219)

Suggest to use `cargo add` in README.md (#222)

Use `SpatialBundle` (#221)

Use `configure_sets` API (#223)

Use `MaterialMesh2dBundle` with `ColorMaterial` (#224)

* Use `MaterialMesh2dBundle` with `ColorMaterial`

* clippy

* Fix green channel filtering bug

* Clippy again

Fix clippy (#229)

* Add `RenderAssetPersistencePolicy` to `Mesh::new` call

* Use built-in `Name` component in `svg` example

Fix CI (#234)

* Use `RenderAssetUsages`

* Specify which `RegularPolygon` to use

Fix CI (#237)

Update Cargo.toml

Update `README.md`

Update CHANGELOG.md
Nilirad added a commit that referenced this pull request Feb 19, 2024
* Use GitHub Actions config from master branch

* Fix formatting

* Fix deprecation warnings on add_plugin

Fix CI (#218)

Fix shader (#219)

Suggest to use `cargo add` in README.md (#222)

Use `SpatialBundle` (#221)

Use `configure_sets` API (#223)

Use `MaterialMesh2dBundle` with `ColorMaterial` (#224)

* Use `MaterialMesh2dBundle` with `ColorMaterial`

* clippy

* Fix green channel filtering bug

* Clippy again

Fix clippy (#229)

* Add `RenderAssetPersistencePolicy` to `Mesh::new` call

* Use built-in `Name` component in `svg` example

Fix CI (#234)

* Use `RenderAssetUsages`

* Specify which `RegularPolygon` to use

Fix CI (#237)

Update Cargo.toml

Update `README.md`

Update CHANGELOG.md
Nilirad added a commit that referenced this pull request Feb 19, 2024
* Squash commit (updates for Bevy 0.13)

* Use GitHub Actions config from master branch

* Fix formatting

* Fix deprecation warnings on add_plugin

Fix CI (#218)

Fix shader (#219)

Suggest to use `cargo add` in README.md (#222)

Use `SpatialBundle` (#221)

Use `configure_sets` API (#223)

Use `MaterialMesh2dBundle` with `ColorMaterial` (#224)

* Use `MaterialMesh2dBundle` with `ColorMaterial`

* clippy

* Fix green channel filtering bug

* Clippy again

Fix clippy (#229)

* Add `RenderAssetPersistencePolicy` to `Mesh::new` call

* Use built-in `Name` component in `svg` example

Fix CI (#234)

* Use `RenderAssetUsages`

* Specify which `RegularPolygon` to use

Fix CI (#237)

Update Cargo.toml

Update `README.md`

Update CHANGELOG.md

* Clippy!!!
Nilirad added a commit that referenced this pull request Jul 5, 2024
* Use `MaterialMesh2dBundle` with `ColorMaterial`

* clippy

* Fix green channel filtering bug

* Clippy again
Nilirad added a commit that referenced this pull request Jul 5, 2024
* Resolve merge conflicts

* Use GitHub Actions config from master branch (#217)

* Use GitHub Actions config from master branch

* Fix formatting

* Fix deprecation warnings on add_plugin

* Fix CI (#218)

* Fix shader (#219)

* Use `SpatialBundle` (#221)

* Use `MaterialMesh2dBundle` with `ColorMaterial` (#224)

* Use `MaterialMesh2dBundle` with `ColorMaterial`

* clippy

* Fix green channel filtering bug

* Clippy again

* Fix CI (#237)

* Rename `Color` to `LegacyColor` (#240)

* Rename usages of `Color` to `LegacyColor`

* Fix tests

* Revert "Rename `Color` to `LegacyColor` (#240)" (#243)

This reverts commit 6918ca1.

* Migrate to `bevy_color` (#242)

* Migrate to `bevy_color`

The example `dynamic_shape` does not work.

* Update palette color usage

* Fix tests

* Fix CI (#244)

* Fix CI

* Update to bevy 0.14 (#247)

* update to bevy 0.14.0-rc.3

* Depend on `main` branch of Bevy

---------

Co-authored-by: Nilirad <gisquerin@gmail.com>

* Fix CI (#248)

* Update Cargo.toml

* Update documents

---------

Co-authored-by: Alix Bott <bott.alix@gmail.com>
Co-authored-by: a <52638772+aMyTimed@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant