Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix installer mis-modifies .bash_profile #3393

Open
rendaw opened this issue Mar 9, 2020 · 3 comments
Open

Nix installer mis-modifies .bash_profile #3393

rendaw opened this issue Mar 9, 2020 · 3 comments
Labels
installer stale

Comments

@rendaw
Copy link

rendaw commented Mar 9, 2020

My .bash_profile ended with a comment and no new line. After running the Nix installer nix-* commands were failing. Checking .bash_profile I see:

# --httptoolkit-end--if [ -e /home/.../.nix-profile/etc/profile.d/nix.sh ]; then . /home/.../.nix-profile/etc/profile.d/nix.sh; fi # added by Nix installer
<EOF>

I imagine adding a newline before writing the line would fix things but I'm not sure if there's more subtletly here.
ajkovar added a commit to ajkovar/nix that referenced this issue Jul 18, 2020
@ajkovar
Add newline to profile sourcing line NixOS#3393
3294b0a
@ajkovar ajkovar mentioned this issue Jul 18, 2020
Merged
edolstra added a commit that referenced this issue Jul 19, 2020
@edolstra
Merge pull request #3834 from ajkovar/source-line-3393
a79b6dd 
Add newline to profile sourcing line #3393
@abathur abathur mentioned this issue Sep 14, 2020
Open
@thufschmitt thufschmitt mentioned this issue Jan 29, 2021
Closed
@stale
Copy link

stale bot commented Feb 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Feb 13, 2021
@abathur
Copy link
Member

abathur commented Nov 2, 2021

#3834 has been released, though that fix itself is broken in at least Ubuntu's /bin/sh; keep tabs on #5459 for future progress.

@stale stale bot removed the stale label Nov 2, 2021
@stale
Copy link

stale bot commented May 1, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
installer stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenkozar @rendaw @abathur