-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build system changes for MinGW support #10329
Conversation
This seems to refer to a "unix" subdirectory that doesn't exist. |
I agree with Eelco that referring to those in advance is a strange division of labor. |
We can build the dep and the our GC code is totally portable, but for some reason we get link errors saying `GC_throw_bad_alloc` is missing.
… `INLCUDE_$(pkg)` vars Separate platform-specific files will allow avoiding a lot of CPP.
1d78fc3
to
77205b2
Compare
OK I removed the unix subdirs, just keeping the |
#10346 follow up issue from review. |
Motivation
These changes are needed to enable a MinGW build. The most interesting part is support for platform-specific subdirectories to avoid excess CPP. They are not yet used, but will be once we start separating out the larger chunks of platform-specific code.
Context
First few commits of #8901
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.