Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system changes for MinGW support #10329

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Mar 26, 2024

Motivation

These changes are needed to enable a MinGW build. The most interesting part is support for platform-specific subdirectories to avoid excess CPP. They are not yet used, but will be once we start separating out the larger chunks of platform-specific code.

Context

First few commits of #8901

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority fetching Networking with the outside (non-Nix) world, input locking labels Mar 26, 2024
@Ericson2314 Ericson2314 changed the title Build sytem changes for MinGW support Build system changes for MinGW support Mar 26, 2024
@edolstra
Copy link
Member

This seems to refer to a "unix" subdirectory that doesn't exist.

@Ericson2314
Copy link
Member Author

Ericson2314 commented Mar 26, 2024

@edolstra Yes, unix (and windows) directories will be filled in the main PR (#8901) as needed, which actually changes the C++. This is just setting up the infra to do so.

@roberth
Copy link
Member

roberth commented Mar 27, 2024

unix (and windows) directories will be filled in the main PR

I agree with Eelco that referring to those in advance is a strange division of labor.
I'd add those references in the commit that actually moves or creates stuff in there.

We can build the dep and the our GC code is totally portable, but for
some reason we get link errors saying `GC_throw_bad_alloc` is missing.
… `INLCUDE_$(pkg)` vars

Separate platform-specific files will allow avoiding a lot of CPP.
@Ericson2314
Copy link
Member Author

OK I removed the unix subdirs, just keeping the INCLUDE_* variables that makes it easy to add them.

@edolstra edolstra merged commit 1b71a42 into NixOS:master Mar 27, 2024
9 checks passed
@Ericson2314 Ericson2314 deleted the mingw-devops branch March 27, 2024 21:17
@Ericson2314
Copy link
Member Author

#10346 follow up issue from review.

jlesquembre added a commit to tweag/nix that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetching Networking with the outside (non-Nix) world, input locking new-cli Relating to the "nix" command windows with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants