Implement runProgram for Windows #10769
Conversation
|
@poweredbypie Thanks again for all your hard work! Feel free to just make some unit tests for |
|
@poweredbypie just checking you are keeping this draft on purpose? |
Yes, I haven't finished the implementation yet so I don't think it's ready to be merged. |
|
All good! I pushed a merge fixing conflicts, and enabling formatting on the file since it is mostly new code :) |
This is incomplete; proper shell escaping needs to be done
|
@poweredbypie BTW, feel free to join the matrix if you want to coordinate on this stuff closer to real-time. |
poweredbypie
force-pushed
the
mingw-spawn
branch
from
7459782
to
d7537f6
Compare
|
Hi, I've re-applied my commits to a more recent version of the master branch to clean up the commit history a bit. I'll be implementing some spawn tests shortly and hopefully those will pass and I'll move this out of draft mode.
Sure, I've joined. Is there a specific room I can join for the windows effort? I skimmed around a bit but I didn't find one. |
|
I believe here: https://matrix.to/#/#windows:nixos.org |
poweredbypie
force-pushed
the
mingw-spawn
branch
from
79e256e
to
50343c1
Compare
poweredbypie
force-pushed
the
mingw-spawn
branch
from
50343c1
to
4f6e3b9
Compare
Apparently, CreateProcessW already searches path, so manual path search isn't really necessary.
|
I've implemented some very basic tests and ran them on my VM successfully, so I'm fairly sure this is ready to be merged now! |
|
Oops sorry I missed this, thanks @poweredbypie! |
Context
Allows actually calling runProgram and runProgram2 on Windows. Closes #10544.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.