Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Interrupted falling out of thread crash #11665

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Fix Interrupted falling out of thread crash #11665

merged 6 commits into from
Oct 16, 2024
+18 −3

Commits on Oct 16, 2024

  1. fix: Ignore Interrupted in recursive-nix daemon worker 

    Otherwise, if checkInterrupt() in any of the supported store operations
would catch onto a user interrupt, the exception would bubble to the thread
start and be handled by std::terminate(): a crash.
    @roberth
    roberth committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0e5a530 View commit details
    Browse the repository at this point in the history

  2. Document recursive-nix startDaemon/stopDaemon

    @roberth
    roberth committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    de41e46 View commit details
    Browse the repository at this point in the history

  3. ThreadPool: catch Interrupted

    @roberth
    roberth committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3f9ff10 View commit details
    Browse the repository at this point in the history

  4. Handle ThreadPoolShutdown with normal catch

    @roberth
    roberth committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    16320f6 View commit details
    Browse the repository at this point in the history

  5. ThreadPool: don't silently ignore non-std exceptions 

    Introduced in 8f6b347 without explanation.

Throwing anything that's not that is a programming mistake that we don't want
to ignore silently. A crash would be ok, because that means we/they can fix
the offending throw.
    @roberth
    roberth committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    fd8a4a8 View commit details
    Browse the repository at this point in the history

  6. Typo 

    Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
    @roberth @cole-h
    roberth and cole-h authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ed184f0 View commit details
    Browse the repository at this point in the history