Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libexpr: add sha256 noop argument to fetch #1538

Closed
wants to merge 2 commits into from
Closed

libexpr: add sha256 noop argument to fetch #1538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3a4a9d
libexpr: add sha256 noop argument to fetch
zimbatm Aug 29, 2017
35c3b05
libexpr: warn if the fetch sha256 argument is being used
zimbatm Aug 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libexpr/primops.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1709,6 +1709,10 @@ void fetch(EvalState & state, const Pos & pos, Value * * args, Value & v,
string n(attr.name);
if (n == "url")
url = state.forceStringNoCtx(*attr.value, *attr.pos);
else if (n == "sha256")
// noop, added for forward-compatiblity
static bool haveWarned = false;
warnOnce(haveWarned, "the fetchurl/fetchTarball sha256 argument is currently ignored. Upgrade to Nix 1.12 to support this feature.");
else if (n == "name")
name = state.forceStringNoCtx(*attr.value, *attr.pos);
else
Expand Down